Forward compatebility with ReactPHP packages#51
Forward compatebility with ReactPHP packages#51WyriHaximus wants to merge 6 commits intoclue:masterfrom
Conversation
|
I've contacted Travis about the missing build. Will comment here once that has been resolved. |
9fdd946 to
eca3e3b
Compare
|
Issues resolved for Travis 🎉 |
|
Failing job is due to travis error with PHP 5.3 |
|
Thank you for filing this PR, much appreciated! I think your suggested changes make perfect sense and now that the (Also thanks for looking into the tests, I'll make sure to take care of the legacy PHP tests) |
|
Unrelated legacy PHP build error has been addressed via #52 |
|
Updated the PR to use streams directly instead of wrapping them in |
… async-STDOUT # Conflicts: # src/Stdin.php # src/Stdio.php # src/Stdout.php
|
@clue any chance of getting this merged? |
|
@mpociot Thanks for the friendly ping :) It's near the top of my current TODOs, expect to see a result some time next week 👍 |
|
That’s great, thank you! |
|
@clue, any status on this? |
|
@marktopper, @WyriHaximus did a very good job at updating dependencies with this PR, but this has been superseded by changes on the |
|
Cool so closing this in that case 👍 🎉 |
🎉